HorizonFFXI / HorizonXI-Issues

Issue Tracker for HorizonXI
14 stars 1 forks source link

🐛[BUG] Souleater, Multi-Hit Weaponskills, and Zanshin #834

Open Ryahask opened 1 year ago

Ryahask commented 1 year ago

What does this bug affect? There's currently a bug with DRK/SAM using Guillotine while under the effects of Souleater. I tested this multiple times and consistently had Souleater consume substantially too much HP (88% from a single Guillotine) without providing the appropriate damage on the WS based on the health drained. As an example, I have had Souleater consume over 1K HP when the Guillotine hit for ~750. I tested this on other subjobs and Souleater was draining the appropriate amount of HP.

This has led me to conclude that Zanshin must be proccing currently on multi-hit weaponskills and that Souleater is interacting improperly with this change. Alternatively, there's a specific bug related to the combination of Souleater, Zanshin, and Multihit WS's. I've eliminated all other JA's and pieces of equipment - however, did notice (anecdotally) that while wearing newly adjusted Ashigaru Earring I tended to lose a higher % of my current HP than without.

This is hard to display properly with screenshots rather than video, but in each of these screenshots my starting health prior to using Guillotine + Souleater was full.


If Zanshin is proccing on multi-hit weaponskills (as I suspect it is), this may be a separate bug in its own right, but I couldn't determine a method to test this apart from the current method of Souleater w/ a multi-hit WS. As I recall (and from some quick research) Zanshin should not be proccing on multi-hit weaponskills.

My theory as to how this bug specifically occurs (as the health % lost is somewhat inconsistent) is that each Zanshin proc is doubling Souleater's health consumption, but not increasing the damage it deals in equilibrium.

Steps to Reproduce Simply use DRK/SAM and open a fight at full HP with a Souleater -> Guillotine and the health removed will consistently be higher than it should be.

Expected behavior If working appropriately, the DRK's current health should be reduced by 48%, but it is consistently higher.

Screenshots The screenshots below were all taken after a single Souleater into Guillotine starting from full HP. Ryahask_2023 01 14_235516 Ryahask_2023 01 14_235941 Ryahask_2023 01 14_230430 Ryahask_2023 01 14_231204 Ryahask_2023 01 14_214551 Ryahask_2023 01 14_232020

By comparison, these two screenshots reflect a before and after of the same ability combination with any subjob other than Samurai. Ryahask_2023 01 14_225130 Ryahask_2023 01 14_225123

siknoz commented 1 year ago

I put this in the ASB one as well, putting here too:

2005 video: https://www.youtube.com/watch?v=YX5rdAu89Hc Does Auto+1257 Guillotine with LR/SE and HP goes from 1006 -> 528 and then heals up to 796 and does another guillotine and HP is reduced to 484. So for both of them he seems to lose ~300hp for a guillotine.

I hopped on retail and fired off a few guillos as well, and it seems to do ~300hp as well.

https://youtu.be/AqeajJTX0Dc https://youtu.be/7YLY-AW5HJg

Wiki: https://ffxiclopedia.fandom.com/wiki/Souleater - "When activated by a Dark Knight, each successful attack that lands (even for zero damage) will cause the user to lose 10% of his/her current HP"

So since Guillo is a 4-hit, means that at the absolute most it would do 40% if all 4 hits landed.

From what I understand it's supposed to do 10% per hit of CURRENT hp, as it states in the wiki. If it's a multi-hit ws like Guillo, means it does 10% of your current HP per hit that lands. So if you hit for 2, does 20% of your current hp, if you hit all 4 its 40%. Seems to line up with the damage in all the videos above.

Edit: Figured I should do one with low hp guillo to show that as well - https://youtu.be/ybvJOB0WTeo