HorizonRobotics / SocialRobot

Apache License 2.0
71 stars 20 forks source link

mesh and texture files of some models is not used #102

Closed Jialn closed 4 years ago

Jialn commented 4 years ago

https://github.com/HorizonRobotics/SocialRobot/pull/97 PR97 added all used gazebo model files into repository, but mesh and texture files of the model that are renamed is not used. The link in the sdf is still the original one. Currently we still need to downloading model files to ~/.gazebo/models to get the texture correctly.

example: here is part of the codes pr2_noplugin.sdf

      <collision name="torso_lift_link_geom">
        <geometry>
          <mesh>
            <uri>model://pr2/meshes/torso_v0/torso_lift_L.stl</uri>
          </mesh>
        </geometry>

Either we should change pr2 in the uri to pr2_noplugin, or remove the mesh and texture file and add originlal pr2/pioneer/youbot to the repo.

le-horizon commented 4 years ago

Good catch Jiangtao! I guess changing URI to pr2_noplugin is the easiest? Thanks!

Jialn commented 4 years ago

Fixed