search

HorizonRobotics / SocialRobot

Apache License 2.0
71 stars 20 forks source link

Bump up gym to 0.15.3 #135

Closed breakds closed 3 years ago

breakds commented 3 years ago

Motivation

  1. This is part of the effort to bring procgen environments to alf
  2. procgen requires gym >= 0.15
  3. After bumping up the version in alf, because alf depends on SocialBot, the gym version become incompatible

Solution

Bump up the version of gym here as well

breakds commented 3 years ago

I am a bit confused by the CI/CD. Experiments done:

  1. Bump gym version to 0.15.3, some tests such as pr2_test failed with not finding gym
  2. Bump gym version to 0.12.6, some tests such as pr2_test failed with not finding gym
  3. Revert gym back to 0.12.5, all tests seems file

However, when I repeat No.1 on my local docker container, it worked fine.

breakds commented 3 years ago

I am a bit confused by the CI/CD. Experiments done:

  1. Bump gym version to 0.15.3, some tests such as pr2_test failed with not finding gym
  2. Bump gym version to 0.12.6, some tests such as pr2_test failed with not finding gym
  3. Revert gym back to 0.12.5, all tests seems file

However, when I repeat No.1 on my local docker container, it worked fine.

This problem is now resolved. It is caused by:

  1. During the CI, the original old gym is removed from /usr/local/lib/python3.6/dist-packages
  2. And the new gym is installed to /usr/lib/python3.6/site-packages

Note that there is a subtle difference in the path. The (hacky) work around is to add the latter to PYTHONPATH. However, I do plan to create a new docker image that unifies the testing environment and its python search paths.