HorizonRobotics / SocialRobot

Apache License 2.0
71 stars 20 forks source link

reset speed to 0 after resetting target #77

Closed le-horizon closed 5 years ago

le-horizon commented 5 years ago

Currently the ball is sometimes rolling after reset. It seems this change makes the ball less likely to roll after reset. Maybe rolling can still happen if ball is initialized to be overlapping with another object in the grocery ground.

After pulling this change, folks will need to do the following to get grocery_ground working:


cd SocialRobot_REPO_ROOT
cd build
cmake ..
make -j```

if ```cmake ..``` complains about cannot find configuration file provided by "gazebo", run
```sudo apt install libgazebo9-dev``` where the version number 9 comes from ```gazebo --version```
Jialn commented 5 years ago

Yes, we only set pose of goal each time. The speed of the ball is kept. There is a success_distance_thresh which will end the episode before the agent knocking the ball. But somehow sometimes the agent knock the ball and cause it get a speed. Actually there is a bug which will be fixed in PR #72 : teacher.teach() should be called after world.step() for both simplenavi and grocery env. So there is 1 step offset of reward calculation and done checking now. This will not be a problem after the bug is fixed.

le-horizon commented 5 years ago

Glad you found the bug of teach before step, Jiangtao! Did you say you tested target reset already? If so, I'll just delete this PR.

Jialn commented 5 years ago

Glad you found the bug of teach before step, Jiangtao! Did you say you tested target reset already? If so, I'll just delete this PR.

Let's check in this pr. It's good to have a model reset function in pygazebo.