Why do not reset cached anchor/feature to None in a new clip

HorizonRobotics / Sparse4D

MIT License

326 stars 31 forks source link

Why do not reset cached anchor/feature to None in a new clip #74

Open zhui064 opened 4 months ago

zhui064 commented 4 months ago

In instance_bank.py, the function reset is only called at the first time entering the function get. But for a new clip, cached anchor/feature is not reset to None. Instead, cached anchor/feature of last clip is used. It maybe a bug but almost no impact on effect ?

linxuewu commented 3 months ago

Yes, this is a bug, but it doesn't affect the outcome significantly.

The correct approach is to use instance_bank.mask for new clips, setting the temporal anchor and feature as the current anchor and feature in the temporal cross attention.