[DISK] Fixes overcounting of APFS on macOS - Githubissues

HorlogeSkynet / archey4

:computer: Maintained fork of the original Archey (Linux) system tool

https://git.io/archey4

GNU General Public License v3.0

291 stars 37 forks source link

[DISK] Fixes overcounting of APFS on macOS #116

Closed HorlogeSkynet closed 2 years ago

HorlogeSkynet commented 2 years ago

Description

Replaces entries of APFS volumes with an aggregated entry for that volume's container.

Reason and / or context

See #115.

How has this been tested ?

[X] Unit tests
[x] macOS runtime

Types of changes :

[X] Bug fix (non-breaking change which fixes an issue)
Typo / style fix (non-breaking change which improves readability)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

[IF NEEDED] I have updated the README.md file accordingly ;
[X] [IF NEEDED] I have updated the test cases (which pass) accordingly ;
[IF BREAKING] This pull request targets next Archey version branch ;
[X] My changes looks good ;
[X] I agree that my code may be modified in the future ;
[X] My code follows the code style of this project (PEP8).

HorlogeSkynet commented 2 years ago

Please PTAL over here too @ingrinder !

I have... :

merged your commits into only one
moved APFS specific code to a dedicated Disk method
reverted your change which skip a test depending on the platform (this is unit testing, I think all of them can run everywhere, aren't they ?)
"harden" the call to diskutil to catch some exceptions
some other minor styles

Thanks again (again), bye :pray: