Apple WWDC 2020 logo variant

twang817 commented 2 years ago

Description

Adds Apple's WWDC 2020 logo as a variant.

Types of changes :

Bug fix (non-breaking change which fixes an issue)
Typo / style fix (non-breaking change which improves readability)
[x] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

[IF NEEDED] I have updated the README.md file accordingly ;
[IF NEEDED] I have updated the test cases (which pass) accordingly ;
[IF BREAKING] This pull request targets next Archey version branch ;
[x] My changes looks good ;
[x] I agree that my code may be modified in the future ;
[x] My code follows the code style of this project (PEP8).

ingrinder commented 2 years ago

I didn't draw this. I came across the wwdc logo and copied it from there.

Are you sure we can add this logo then? I'm not 100% sure on the intricacies of licensing here, but I would surmise that we can't relicense the work made by Apple... If it were recreated in the same style, I would suppose that might count as an "original" work.

twang817 commented 2 years ago

I didn't draw this. I came across the wwdc logo and copied it from there.

Are you sure we can add this logo then? I'm not 100% sure on the intricacies of licensing here, but I would surmise that we can't relicense the work made by Apple... If it were recreated in the same style, I would suppose that might count as an "original" work.

I honestly didn't give it anywhere near this much thought. The picture isn't exactly the same. I used a random generator for the internal symbols and randomized the colors.

That being said, if there are issues, I would wonder what the legality of any of the logos/trademarks are. I suspect that there isn't anyone that's going to get upset with this use case.

If the size is a concern, I'd happily share my Python code that generates the ascii file. It's stupid code, done in a hurry. Perhaps it could be worked into something that generates and caches the logo on first load.

As for shrinking it, I really don't have a single artistic bone in my body. Perhaps someone else will come along and redo this in a smaller size.

Really, I made this change for my own use. I've always liked this graphic, and I thought I'd share. I'm not trying to sound stand-offish, but at this point, it's entirely up to you.

HorlogeSkynet commented 2 years ago

I'll try to work on this within some days :+1:

HorlogeSkynet commented 2 years ago

So I caught a glimpse of it, my points below :

License should not be an issue here (partly-related : dylanaraps/neofetch#170). But that raised a question though, under which license the Reddit OP released this ? :sweat_smile:
This logo is definitely too big ;
The Reddit thread had been started 6 years ago : is this really the WWDC 2020 logo ?
If there are some unmatched {, please prefer escaping them ({{) :wink:
Would your script be able to output something like ~20/30 lines high ? "Resolution" wouldn't look clean as yours but maybe it can be a good trade-off ?

Thanks again, bye :pray:

twang817 commented 2 years ago

I've uploaded the code I used to generate this. I wrote this some time ago, and revisited it today.

A couple points:

It uses ply. A bit crazy, but I must have been in a lex-yacc mood that day.
It generates from an existing logo. It figures out the edges to retain shape and then figures out how to follow a word/non-word pattern and randomize the symbols, words, and colors.
It does have a stretch built in that can stretch it horizontally. I think I used this to accommodate for fonts that may be skinnier than they are tall.

I don't know how useful this is to your requirements and/or goals.

You can find the gist here: https://gist.github.com/twang817/30dacccd1c9a29fe159157027e9c462c

HorlogeSkynet commented 1 year ago

Hey @twang817, sorry for the delay.

So I've checked your gist, see below my points/suggestions :

The logo height seems OK (it is pretty "tall" according to others, but it is not very important)
Do you think you can (with your script of course) colorize tokens using the {c[N]} syntax (literally 6 bytes in the end source code) instead of explicit control characters (i.e. \033[...) full format ?
Of course, you can provision a (Python) list COLORS_WWDC containing all the colors that are needed.
If it's still "too big", maybe we can limit coloration to a subset of tokens (words and specific characters tokens) ?

Thanks again, bye :wave:

ingrinder commented 1 year ago

I noticed this has been around for a while so I've had a bit of a go at addressing some of the above concerns.

I forked the gist with a few small changes to get it to output an Archey-style logo and dirtily remove redundant colour codes - https://gist.github.com/ingrinder/9e68f7bd1e2d8c9d86a0a5a594a64e1d

I also made some tentative changes to allow the specific colours to be used by adding 256-colour support, see the logo/apple_wwdc20 branch.

It's still "big", at 8K and 36 lines, but it looks fairly decent to me despite the size? I suppose the big empty space satisfies the Apple aesthetic...! I wouldn't really know how to start removing lines from the logo without redrawing the whole input one by hand. @HorlogeSkynet if you think this is viable, perhaps I could write some tests and @twang817 could pull it into this PR?

HorlogeSkynet commented 1 year ago

Thanks @ingrinder for the hard work !!! I'm ready to review a PR for your branch 🙏

ingrinder commented 1 year ago

@twang817 I pushed onto the end of your fork, I hope that's okay - it seemed easier than making a separate PR, and I believe you won't lose credit in the commit once it's merged that way.

@HorlogeSkynet I think this is ready for review, I added tests and squashed together some of my commits. Quick overview of changes:

Splits Colors class into Style base class for general formatting stuff (possibility for extension in future with other attributes)
Adds Colors8Bit class extending Style to allow 256 colour mode text to be used (as in this PR)
Adds modified WWDC20 logo in "Archey style" from gist linked above
Unit tests for new classes

Let me know what you think :+1:

ingrinder commented 1 year ago

@HorlogeSkynet Rebased on master and squashed into 2 commits - I removed the AttributeError check as you said. Should be good to merge if you're happy :tada:

HorlogeSkynet commented 1 year ago

Many thanks @ingrinder :pray: @twang817 This will be released in the next Archey version, optimistically before the end of July.

HorlogeSkynet / archey4