HorlogeSkynet / archey4

:computer: Maintained fork of the original Archey (Linux) system tool
https://git.io/archey4
GNU General Public License v3.0
291 stars 37 forks source link

[DISTROS] Adds support for Nobara #131

Closed Snootiful closed 1 year ago

Snootiful commented 1 year ago

Description

This PR adds ASCII art for the Nobara Project. (The ASCII art was not made by me, but using an ASCII art generator. I would like to encourage someone who has experience making ASCII art to improve this icon.)

I have not merged the branch I created with the master branch. As this PR should not cause merge conflicts I will leave the merging to whoever accepts this PR.

Also, the provided screenshots show warnings about temperature sensors. This warning also appears without my changes, because this is an issue with my system. The warnings are not related to the changes this PR makes.

Reason and / or context

This PR was created to support the Nobara Project. The Red Hat logo would show without this PR.

How has this been tested ?

Environment: Tested this PR on my machine running Nobara 37 using both the fish and bash shell. Should work on other machines too since the code in this PR matches that of other PRs that add logos for various distros.

archey-fish

archey-bash

Built using PEX:

archey-build-pex

Types of changes :

Checklist :

Snootiful commented 1 year ago

Thanks for the quick reply :)

The reason I added the Pylint flag and the leading whitespace was because I used the Red Hat logo as reference. I also don't have Pylint installed because I don't often program in Python.

I have removed one space from each line of the logo and removed the Pylint flag as suggested.

Snootiful commented 1 year ago

Oh, and I just noticed that I left a trailing comma on the LOGO array, which doesn't follow the code style from PEP8. My apologies, feel free to remove that comma.

HorlogeSkynet commented 1 year ago

Oh, and I just noticed that I left a trailing comma on the LOGO array, which doesn't follow the code style from PEP8.

Don't worry it's actually OK. We use Black code formatter over here, which makes sure there are trailing commas for multiple lines object definitions.