Closed Tobilike closed 10 months ago
I have noticed the following: Integration / Lint Python sources (pull_request) What exactly is the problem here?
Run black --check --diff archey/
--- /home/runner/work/archey4/archey4/archey/entries/desktop_environment.py 2024-01-10 10:57:56.557093+00:00
+++ /home/runner/work/archey4/archey4/archey/entries/desktop_environment.py 2024-01-10 10:58:29.108694+00:00
@@ -23,10 +23,11 @@
class DesktopEnvironment(Entry):
"""
Just iterate over running processes to find a known-entry.
If not, rely on the `XDG_CURRENT_DESKTOP` environment variable.
"""
+
_ICON = "\ue23c" # fae_restore
_PRETTY_NAME = "Desktop Environment"
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
would reformat /home/runner/work/archey4/archey4/archey/entries/desktop_environment.py
Oh no! 💥 💔 💥
1 file would be reformatted, 106 files would be left unchanged.
Error: Process completed with exit code 1.
That error is from the code formatter, black
- it is saying there should be an additional empty newline after the docstring.
Thank you. I will always use Black now.
@Tobilike I just pushed a small change, hope that's alright. This LGTM now!
@ingrinder I just pushed a small change, hope that's alright.
I have no problem with something like that.
[Merge remote-tracking branch 'origin/Icons' into Icons](https://github.com/HorlogeSkynet/archey4/pull/144/commits/1700e9ec562babb24725ed783d52e162d555622b)
I must have done something wrong with git at the moment. Give me some time to understand. Everything is fine in my local copy.
This behaves strangely. Python -m unittest reads ~/.config/archey4/config.json but not [root]/config.json Python -m archey reads [root]/config.json but not ~/.config/archey4/config.json
There are security checks done on file permissions. But unit tests must not depend on external environment.
Thank you, now I understand it better.
Hello @Tobilike, I've pushed some changes :
Configuration
in Entry
Please tell me what you think about them before we merge this branch :slightly_smiling_face:
Bye :wave:
I've looked at it, tested it, and I think it's great.
And thanks to HorlogeSkynet, ingrinder for the teamwork. I was able to learn a lot from it.
Possibly all of them have now worked:
Please have a look there:
141