[WINDOW_MANAGER] Adds display server protocol to entry

HorlogeSkynet commented 10 months ago

See #142.

How has this been tested ?

Unit tests and locally (Debian 11).

Types of changes :

Bug fix (non-breaking change which fixes an issue)
Typo / style fix (non-breaking change which improves readability)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

[IF NEEDED] I have updated the README.md file accordingly ;
[X] [IF NEEDED] I have updated the test cases (which pass) accordingly ;
[IF BREAKING] This pull request targets next Archey version branch ;
[X] My changes looks good ;
[X] I agree that my code may be modified in the future ;
[X] My code follows the code style of this project (PEP8).

HorlogeSkynet commented 10 months ago

So I've checked how UI layering works and it appears showing DSP info in DE entry would be more consistent. Tell me what you think about it @Tobilike @ingrinder :pray:

ingrinder commented 10 months ago

Hmmm, how come? As far as I know you can run independent window managers without a "DE" as such in X and Wayland (e.g. i3, weston), so does it not make more sense there?

Tobilike commented 10 months ago

I tested it on Hyprland and xmonad. It is displayed in the correct place. As long as it is displayed in windows manager. Everything is fine. Technically, you can run x11 without everything, but it doesn't really make sense. You can't do anything.

Very nice work by the way. It's much better integrated.

HorlogeSkynet commented 10 months ago

Thanks for your feedbacks (I am not an expert in UI environments at all). I've reverted to first proposal (including your CHANGELOG suggestion Michael).

Bye :wave:

HorlogeSkynet / archey4