[GPU] Parses `lspci` to avoid classing 3D NAND devices as GPUs.

ingrinder commented 5 months ago

Fix for #149.

Description

Parse lspci -m (ie machine readable format) to only match on the PCI class rather than the entire vendor + product string.

Reason and / or context

See #149 :grin:

How has this been tested ?

Seems to work fine on my systems, modified tests pass.

Types of changes :

[X] Bug fix (non-breaking change which fixes an issue)
Typo / style fix (non-breaking change which improves readability)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

[IF NEEDED] I have updated the README.md file accordingly ;
[X] [IF NEEDED] I have updated the test cases (which pass) accordingly ;
[IF BREAKING] This pull request targets next Archey version branch ;
[X] My changes looks good ;
[X] I agree that my code may be modified in the future ;
[X] My code follows the code style of this project (PEP8).

HorlogeSkynet commented 5 months ago

Hey @ingrinder, thanks for this fast PR !! I wonder why I initially didn't pass -m to lspci, maybe due to flag support across platforms ? 🤔

ingrinder commented 5 months ago

I thought the same thing too -- but we only use lspci on Linux, where I believe it is only supplied by Martin Mareš's pciutils. The m option was added to it in 1998!

HorlogeSkynet commented 5 months ago

Awesome patch, thanks ! I'll try to merge this soon and release a new version ASAP. We'll postpone ongoing work to a future release this year 😇

HorlogeSkynet / archey4