HorlogeSkynet / archey4

:computer: Maintained fork of the original Archey (Linux) system tool
https://git.io/archey4
GNU General Public License v3.0
295 stars 37 forks source link

[GPU] Adds support for Raspberry Pi (VideoCore chipsets) #157

Closed HorlogeSkynet closed 1 month ago

HorlogeSkynet commented 2 months ago

See #130.

How has this been tested ?

Unit tests and Raspberry Pi 1 (running as root).

Types of changes :

Checklist :

MatsA commented 2 months ago

Hi ! Nice ! Please advice how to test. /Mats

HorlogeSkynet commented 2 months ago

Sure, first you need to Git clone the project and then checkout the feat/raspberry_pi_gpu branch. From there you can then create a Python virtual environment and install dependencies, before running Archey from sources :

python3 -m venv venv && source venv/bin/activate
pip install -e .
python3 -m archey

Please note that if your configuration isn't "locked" (see allow_overriding config option), shipped config.json will be preferred over your system/user configuration (if you have any).

Thanks for your time, bye 👋


EDIT : :warning: important note, reading in /sys/kernel/debug may require root privileges

HorlogeSkynet commented 2 months ago

Up @MatsA / @ingrinder :bow:

MatsA commented 2 months ago

Sorry, my bad....

Not that good in git cli so googled little and did as below

As said using RPi 5 with desktop

/Mats

git clone -b feat/raspberry_pi_gpu https://github.com/HorlogeSkynet/archey4.git
cd archey4
python3 -m venv venv && source venv/bin/activate
pip install -e .
(venv) pi@test:~/archey4 $ python3 -m archey

Skärmavbild 2024-08-31 kl  22 03 43

HorlogeSkynet commented 2 months ago

Thanks for trying ! So I guess GPU detection works, but running as root caused WM & DE to be missing. Maybe running with sudo would satisfy everyone, but that's another concern.

I'm waiting for @ingrinder review before merging this. Thanks again, bye 👋

MatsA commented 2 months ago

I'm waiting for @ingrinder review before merging this. Thanks again, bye 👋

Hi, nice I could help. Maybe you shouldn't have high hopes for a ingrinder response since he haven't been active for half a year..... and a student 😉.... maybe having much other things up and running ?

/Mats

HorlogeSkynet commented 2 months ago

Hi, nice I could help. Maybe you shouldn't have high hopes for a ingrinder response since he haven't been active for half a year..... and a student 😉.... maybe having much other things up and running ?

Indeed, I hope he's okay. Unfortunately he's the only other maintainer here, and I usually prefer multiple positive reviews before merging something (mostly when it's my own code :upside_down_face:). We're already late for the v4.15 release, I plan to wait until the end of the month before merging everything and eventually releasing it.

Bye :wave:

HorlogeSkynet commented 2 months ago

(branch has been rebased and AppArmor profile extended according to new opened/read files)