search

HorlogeSkynet / archey4

:computer: Maintained fork of the original Archey (Linux) system tool
https://git.io/archey4
GNU General Public License v3.0
291 stars 37 forks source link

[FEATURE] Add a --no-logo flag #158

Closed petdance closed 4 weeks ago

petdance commented 1 month ago

Describe the solution you'd like

I'd like to be able to run archey without the ASCII art. It's nice the first dozen times but after that, it's noise. All my boxen are RHEL anyway, so it's never helpful for me to have a visual indicator.

Describe alternatives you've considered

I've poked in the config.json, and looked at the code, and I don't see anything that allows the logo to be skipped. I did try hacking up my /usr/local/lib/python3.6/site-packages/archey/logos/rhel.py to have LOGOS only contain empty strings. That works OK, although it does leave a three-space gutter on the left. I'd rather not have to Ansible out a hacked version of that file to all my machines if I don't have to.

HorlogeSkynet commented 1 month ago

Hello @petdance ! Sure, let's include such an option in the next release 🙂

petdance commented 1 month ago

Sounds good. Is there something you need me to do? I'm not sure who "us" in "let's include" is.

HorlogeSkynet commented 1 month ago

I'll try to implement that, if you could stay around to review/test the feature it would already be awesome.

petdance commented 1 month ago

Just let me know and I can try things out. I'm not well versed in installing Python packages, though, so it may be a learning experience for me.

HorlogeSkynet commented 1 month ago

Hey @petdance, please see #159 for implementation proposal. If you clone the Git project and checkout the feat/no_logo branch, you can then execute the following commands to run Archey from sources :

python3 -m venv venv && source venv/bin/activate
pip install -e .
python3 -m archey --logo-style none

Thanks for your time, bye :wave:

petdance commented 1 month ago

It works for me.

One thing I note is that the labels in the output take on the color of COLORS[0] but since there are no colors with --logo-style none, the labels are always just plain text. That's not a problem to me. Just observing.

HorlogeSkynet commented 1 month ago

Indeed, entry colors are based on "main" logo colors. Without loading a logo, this implantation cannot infer any color for entries 🤡

Although, entries_color configuration option should still apply, WDYT about the global idea here ?

Thanks bye 👋

petdance commented 4 weeks ago

I don't have a concern about it. I was pointing it out. It's all good with me.