HorlogeSkynet / archey4

:computer: Maintained fork of the original Archey (Linux) system tool
https://git.io/archey4
GNU General Public License v3.0
291 stars 37 forks source link

Test cases, setuptools, documentation, optimizations, software architecture and code styles #24

Closed HorlogeSkynet closed 6 years ago

HorlogeSkynet commented 6 years ago

It should have only been a test cases implementation, but eventually it is a major rewriting.

Description

Project :

Features :

Reason and / or context

It was very boring of manually testing each class by tweaking the source code. During implementation of unit tests, some new stuffs have been discovered in the documentation, and were added.

How has this been tested ?

It'd be a good thing if you'll be able to test this on your system, mostly LAN_IP and WAN_IP entries 🙂

Types of changes :

Checklist :


Thanks for your time, and sorry for the past weeks notifications 😕 Any feedback will be appreciated, as always !

HorlogeSkynet commented 6 years ago

Thanks for the feedback, it's pretty cool ! I'd like to wait for (at least) @Si13n7's thought (as he has a complex network setup) to be sure before merging this 🙇

PS : I've run some tests on a private repository, I'll set up Travis just after this PR 😉

adjagu commented 6 years ago

You're quite welcome @HorlogeSkynet. Hopefully everything tests good for @Si13n7 and this can be merged. :)

Si13n7 commented 6 years ago

Runs without any issues! :smile:

Test Environments:

HorlogeSkynet commented 6 years ago

Perfect thank you, I'll try to draw the release today ! Bye 👋