[BUG] Doesn't fit terminal size

HorlogeSkynet / archey4

:computer: Maintained fork of the original Archey (Linux) system tool

https://git.io/archey4

GNU General Public License v3.0

291 stars 37 forks source link

[BUG] Doesn't fit terminal size #63

Closed SomethingGeneric closed 4 years ago

SomethingGeneric commented 4 years ago

Describe the bug Some lines of archey system info wrap to next line on Ubuntu 20.04 80col x 24row

Expected behavior Regular system info display

Screenshots (note: "Reminders" is my own program. I'm talking about archey above it.) Screenshot from 2020-04-26 14-35-27

Environment

Version used (4.Y.Z) : 4.7.1
Method of installation (distribution package, PyPI, sources) : .deb package
Hardware type (laptop, server, Raspberry, hyper-visor) : Custom built desktop tower
Python version (3.Y.Z) : 3.8.2
Operating system and version : Ubuntu 20.04
Graphical environment name and version : Gnome 3.34 (I think, per Ubuntu "Software")
Connectivity (off-line, LAN only, Internet access) : Ethernet access

Additional context Just installed 20.04 "the debian way" so maybe this is a OS issue, but I figured I'd report anyway.

SomethingGeneric commented 4 years ago

I just made 100% sure that my own program is not the issue. Still could potentially be any number of things w/ the new Ubuntu release.

HorlogeSkynet commented 4 years ago

Hi, thanks for your report ! It's actually a "known-bug", and "officially" since... this morning.

We'll be working on this soon, bye 👋

ingrinder commented 4 years ago

I've pushed some output changes I was working on yesterday to rework/output which should enable the wrapping that @HorlogeSkynet mentioned in the comment this morning a lot easier - I believe it should now be possible to wrap to the terminal size reported by os.get_terminal_size. I'll let you know in a few minutes 😄

SomethingGeneric commented 4 years ago

@ingrinder glad to hear it!

ingrinder commented 4 years ago

@SomethingGeneric is this the behaviour you'd like? Here's how my output looks at 80x24 with commit e5dca9dbf85644fde197d4a66f90213c15c283a7 above.

I'm thinking it could be possible to wrap lines and display them underneath, but a lot harder, so if this truncation with a ... is fine we can stick with that 😃

SomethingGeneric commented 4 years ago

@ingrinder that's perfect! I don't particularlly care myself about having my IP's show (since I know them), and that's much better than having the lines extend and cut stuff off.

HorlogeSkynet commented 4 years ago

Closing here as #64 is on its way. Will be reviewed soon 👌

HorlogeSkynet commented 4 years ago

Hey @SomethingGeneric ! Sorry for the delay, the patch is now available in the latest release :ok_hand: