[WAN_IP] Reworks for configuration, DRY and performance purposes - Githubissues

HorlogeSkynet / archey4

:computer: Maintained fork of the original Archey (Linux) system tool

https://git.io/archey4

GNU General Public License v3.0

291 stars 37 forks source link

[WAN_IP] Reworks for configuration, DRY and performance purposes #89

Closed HorlogeSkynet closed 3 years ago

HorlogeSkynet commented 3 years ago

Description

Fixes IPv6 detection in some particular cases (behind a NAT46)
Speeds up dig usage failing when no IPv6 are available
DNS or HTTP external requests can now be disabled from configuration (closes #81)
DNS or HTTP resolvers can now be changed from configuration
Factorizes internal code to DRY
DNS and HTTP timeouts are now uncoupled and may be different

Bonus : Fixes some code styles issues found afterwards.

Reason and / or context

See #81.

How has this been tested ?

Locally, and unit tests.

Types of changes :

[X] Bug fix (non-breaking change which fixes an issue)
Typo / style fix (non-breaking change which improves readability)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

[X] [IF NEEDED] I have updated the README.md file accordingly ;
[X] [IF NEEDED] I have updated the test cases (which pass) accordingly ;
[X] My changes looks good ;
[X] This pull request targets the develop branch ;
[X] I agree that my code may be modified in the future ;
[X] My code follows the code style of this project (PEP8).

HorlogeSkynet commented 3 years ago

Merged due to age (cc @ingrinder & @mrzv).