search

HorridTom / AE-app

Analysis of publicly available NHS A&E data
Apache License 2.0
1 stars 0 forks source link

Provider name changes not reflected in chart titles #32

Open HorridTom opened 5 years ago

HorridTom commented 5 years ago

At present the app takes the provider name from the earliest date's data. So if a provider's name (but not code) has changed at some point in the past, the name shown by the app will be the oldest name for that provider code, not the latest. This should be changed so that the most current name is displayed.

It would also be good to add a note somewhere on the analysis page for such cases, indicating all the names that have been used for that provider code over time. This would help users avoid confusion over apparent mismatches between periods of names and data associated with a provider code.

For example, code RTV was associated with the name "5 Boroughs Partnership NHS Foundation Trust" during July 2015 - March 2016, and "North West Boroughs Healthcare NHS Foundation Trust" from April 2016 until (at least) December 2018. We are assuming, from the fact that the provider code is the same, that this is a renaming of the same organisation (not two completely different organisations). So a user who knows that 5 Boroughs doesn't exist any more, or who is looking for North West Boroughs, will be confused. Equally someone who knows that North West Boroughs did not exist prior to April 2016 would be confused to see data for e.g. July 2015 - hence the need for an explanatory note.

HorridTom commented 5 years ago

Note: in fact it seems that the current behaviour is different for the performance and volume charts!

https://github.com/HorridTom/AE-app/blob/bb8415764ec1710250e9c4c2df5c0fd7fe371ecc/perf_4h_analysis.R#L147

https://github.com/HorridTom/AE-app/blob/bb8415764ec1710250e9c4c2df5c0fd7fe371ecc/perf_4h_analysis.R#L228

As part of resolving this issue, it would be worth making these all consistent.

gabrielburcea commented 5 years ago

I think this is the same as the issue with weekly display of Queen Elizabeth hospital (Scotland) - but please check as part of this issue. (TW commenting as GB!!)