HorseNuggets / TerminatorPlus

the epic plugin
Eclipse Public License 2.0
148 stars 53 forks source link

[Bug]: Slient client-side exception during player spawning #16

Closed ThisTestUser closed 3 years ago

ThisTestUser commented 3 years ago

What happened?

Whenever a bot is spawned, an error appears in the log. This was tested to appear in vanilla 1.16.5 and doesn't affect bot rendering, but it is annoying because it quickly fills up the logs with spam.

Plugin Version

3.1-BETA

Server Version

Spigot 1.16.5

Relevant log output

[Render thread/FATAL]: Error executing task on Client
java.lang.NullPointerException: null
    at dwu.a(SourceFile:581) ~[1.16.5.jar:?]
    at or.a(SourceFile:57) ~[1.16.5.jar:?]
    at or.a(SourceFile:11) ~[1.16.5.jar:?]
    at ol.a(SourceFile:21) ~[1.16.5.jar:?]
    at ol$$Lambda$3410/1087242415.run(Unknown Source) ~[?:?]
    at aob.c(SourceFile:144) [1.16.5.jar:?]
    at aof.c(SourceFile:23) [1.16.5.jar:?]
    at aob.y(SourceFile:118) [1.16.5.jar:?]
    at aob.bl(SourceFile:103) [1.16.5.jar:?]
    at djz.e(SourceFile:1015) [1.16.5.jar:?]
    at djz.e(SourceFile:681) [1.16.5.jar:?]
    at net.minecraft.client.main.Main.main(SourceFile:215) [1.16.5.jar:?]
Deobfuscated stacktrace (top 3 lines):
java.lang.NullPointerException: null
    at net.minecraft.client.network.play.ClientPlayNetHandler.handleSpawnPlayer(ClientPlayNetHandler.java:719) ~[bin/:?]
    at net.minecraft.network.play.server.SSpawnPlayerPacket.processPacket(SSpawnPlayerPacket.java:68) ~[bin/:?]
    at net.minecraft.network.play.server.SSpawnPlayerPacket.processPacket(SSpawnPlayerPacket.java:1) ~[bin/:?]

Additional Context

This issue goes away if PacketPlayOutPlayerInfo is sent before the entity is added through nmsWorld.addEntity(bot) in net.nuggetmc.tplus.bot.Bot.

Checklist