search

HorseNuggets / TerminatorPlus

the epic plugin
Eclipse Public License 2.0
145 stars 53 forks source link

Use maven project.version placeholder for plugin version, moved 3.1-BETA to the version tag in pom.xml #18

Closed Badbird5907 closed 3 years ago

Badbird5907 commented 3 years ago

I think i did a PR correctly for once in my life

Badbird5907 commented 3 years ago

oops it dosen't work, will fix image

Badbird5907 commented 3 years ago

alright fixed it: image added

 <resources>
            <resource>
                <directory>src/main/resources</directory>
                <filtering>true</filtering>
            </resource>
        </resources>

to the pom and commented out

<transformers>
                        <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
                    </transformers>