HorseNuggets / TerminatorPlus

the epic plugin
Eclipse Public License 2.0
148 stars 53 forks source link

[Suggestion]: Allow spaces in names #39

Open HyperSkys opened 3 years ago

HyperSkys commented 3 years ago

Feature Request

Allow spaces in names by putting name with a '-' will put a space in it so you can put words in it and you can change the skin with the other command anyways

Alternative Options

There isn't really much I can do at that time

Additional Context

No response

Checklist

Legit4K commented 3 years ago

It would cause some compatibility issues with the server and existing plugins, so it's probably not worth it

Badbird5907 commented 3 years ago

well what kind of plugins though? i think its possible

HyperSkys commented 3 years ago

It would cause some compatibility issues with the server and existing plugins, so it's probably not worth it

No it wouldn't you can do it in citizens and nobody has seen any problems with it

HyperSkys commented 3 years ago

It would cause some compatibility issues with the server and existing plugins, so it's probably not worth it

as well it would actually be a nice feature to add, would allow youtubers and content creators to have cool names, so if someone wanted to name the bot The Epic Destroyer Man it would 100% look pretty cool and as well you'd be able to add color codes to the name making the names colorful and as well

ConnorCogged commented 2 years ago

Doesn't citizens use packets instead of players? Or if they actually somehow spawn the PlayerEntity maybe they remove spaces in the name and modify the name using packets (if thats even possible)

Badbird5907 commented 2 years ago

I think its possible to modify it with packets https://wiki.vg/Protocol#Player_Info

HyperSkys commented 2 years ago

Doesn't citizens use packets instead of players? Or if they actually somehow spawn the PlayerEntity maybe they remove spaces in the name and modify the name using packets (if thats even possible)

Citizens build a string based on the arguments that you provide and sets the NPC's display name to the return value of StringBuilderObeject#toString()

Badbird5907 commented 2 years ago

Obeject

nice.

HyperSkys commented 2 years ago

Obeject

nice.

lol

Badbird5907 commented 2 years ago

turns out that citizens actually sets the name to something like CIT-<random str>, then spawns a hologram above their name (see https://github.com/Badbird-5907/AntiCombatLog/issues/6)

notstevy commented 2 years ago

I have a litte workaround for you:

1. /team add something
2. Goto minecraftjson.com and type "/team modify something prefix %s" in the command field. Here you can type the bot name with spaces.
3. Now create the bot if you haven't done yet.
4. /team join something @e[name=botname]

Example:

1. /team add something
2. /team modify something prefix {"text":"This is a ","color":"#00FF91"}
3. I also added a color for the bot name with /team modify something color red
4. /bot create bot
5. /team join something @e[name=botname]
Badbird5907 commented 2 years ago

We could implement something like that with the teams object in the bukkit API but that isn't of highest priority yet.