search

Horsey- / Horseys-Simply-Love

A recreation of hurtpiggypig's Simply Love SM3.95 theme made to now run in StepMania 5
Other
8 stars 3 forks source link

Another Attempt To Fix Memory Leak in SRPG6 #4

Closed JoseVarelaP closed 2 years ago

JoseVarelaP commented 2 years ago

Doing this process removes the need to generate separate versions, however it comes at the potential for special case backgrounds to not show up, as mentioned by Horsey.

(May not be needed as this commit https://github.com/Horsey-/Simply-Love-SM5-1/commit/7a1b7db649825ca48adf587fce10cd9281f8ecfd is already pushed)

I try to make all my changes to Simply Love be easily tracked for when I have to rebase to the latest version, so making that change in the way backgrounds are loaded, it'll run into issues later when there are other special backgrounds added.

The main limiting factor is the fact that every time _shared background is loaded, it will load a kind of screen depending on which one it is in.

JoseVarelaP commented 2 years ago

Actually I need to reconsider my last comment, as the theme already changes the image on the fly via a MessageCommand.

https://github.com/Horsey-/Simply-Love-SM5-1/blob/cc8332c6c73826709c072d65db1ac5a21ae8baf1/BGAnimations/_shared%20background/Static.lua#L51-L65

Horsey- commented 2 years ago

My game has been running on SSM now for a little over 2.5 hours with the latest commit (https://github.com/Horsey-/Simply-Love-SM5-1/commit/7a1b7db649825ca48adf587fce10cd9281f8ecfd), so I think it’s working without issue; since this is the simplest edit I can make, I’ll go with that for now but absolutely revisit this if I have to. I can always use an .redir if I have to in the future.

I hope that doesn’t harm any feelings🙂 I very much appreciate the help looking into this.

JoseVarelaP commented 2 years ago

I've redone the entire process as I've saw the questions about the leak concerning again. So in this method, instead of Loading to the same sprite, we're deleting the entire actor and loading only when needed.

Horsey- commented 2 years ago

the Make SSM background be the same as SWME commit shouldn't be there in this pull request because it's out of date (it references SRPG5)

JoseVarelaP commented 2 years ago

Dropped the commit, should be good to review.