Horsey- / Horseys-Simply-Love

A recreation of hurtpiggypig's Simply Love SM3.95 theme made to now run in StepMania 5
Other
8 stars 3 forks source link

Combo Color Per-user preference in Advanced Options #8

Open Horsey- opened 6 months ago

Horsey- commented 6 months ago

I'd really like to extend the Combo Color preference in metrics.ini (which is read in Graphics/Player Combo.lua) to be a preference each player can select for themselves.

The metrics preference can be located at: PercentUntilColorCombo

To recap: Combo Color refers to the color that the player's consecutive notes hit combo will change based on what kind of full combo the player is holding. When the player is holding a Fantastic combo, the color of the combo counter turns blue (orange for excellent combo, green for great combo).

The default behaviour for this coloring of the combo is to only begin coloring the combo counter once 20% of the song has been played through. I personally think that combo colors should show up immediately, but I think this would be an overly controversial change. I think it would be best to leave this as a player preference.

I think it would be most appropriate to give each player the option of starting the combo color:

  1. Immediately
  2. 20%
  3. 40%
  4. 60%
  5. 80%
  6. Never

As as aside, all themes that I'm aware of have hard-coded the preference to begin combo counting at 4 consecutive notes hit (start a full combo at 4). The above implementation should not clash with this preference, since the combo counter would be hidden anyway.