search

HorzaGobuchul / Amateur-Voat-Enhancements

AVE is a light Enhancement Suite for Voat.co
https://voat.co/v/ave/
MIT License
6 stars 5 forks source link

Chrome manifest seems broken #9

Closed LudwikJaniuk closed 8 years ago

LudwikJaniuk commented 8 years ago

Hey, the manifest in the Chrome folder seems broken and misses various pieces. However, since you do seem to have the plugin out on Chrome, does that mean I'm doing the building wrong? How should I get the plugin fired up?

HorzaGobuchul commented 8 years ago

You are probably doing everything fine. The file in the repo is indeed broken, it is the pre-build one. The version property is missing because it is added by the build script.

To get the actual manifest.json file, open the .crx file as an archive, it will be in the root folder.

LudwikJaniuk commented 8 years ago

Ok. Didn't know what userscript was, thought maybe it was a build system you were using.

On Wed, Jan 27, 2016, 21:04 Horza notifications@github.com wrote:

You are probably doing everything fine. The file in the repo is indeed broken, it is the pre-build one. The version property is missing because it is added by the build script.

To get the actual manifest.json file, open the .crx file as an archive, it will be in the root folder.

— Reply to this email directly or view it on GitHub https://github.com/HorzaGobuchul/Amateur-Voat-Enhancements/issues/9#issuecomment-175827504 .

LudwikJaniuk commented 8 years ago

So how exactly does building work? The manifest file inside there is indeed valid, but how should I go about packaging it for Chrome? Does the manifest have to be placed in a specific folder, if so, which one? I did use the google general guide, but there were errors.

LudwikJaniuk commented 8 years ago

Or, "packaging" as it's called

HorzaGobuchul commented 8 years ago

If you are using the extension with Chrome there is no real "building". Simply unpack the .crx file somewhere, go to chrome://extensions/, enable "developer mode", then "load unpacked extension".

To pack later, click "pack extension..."

LudwikJaniuk commented 8 years ago

In that case, how does code from /src get in to the package? Should I update it manually?

HorzaGobuchul commented 8 years ago

I suggest you work directly on these files. The ./src root files go in ./Core and those in ./src/features go in ./Modules. But if you unpacked the .crx files it should already be set up like this

Personally, I work on the files in ./src and my build system copy them over to ./Core and ./Modules.

LudwikJaniuk commented 8 years ago

Oh, ok, thenI know how to set it up. I'll see it htere are any more errors

LudwikJaniuk commented 8 years ago

Hey, mind sharing that build system tho?

HorzaGobuchul commented 8 years ago

Well... It's not that I don't particularly want to. But it's really written ad hoc for my particular folder arrangement (a bit far from the repo's).

I'll have to modify it a bit before releasing it.

LudwikJaniuk commented 8 years ago

Oh, don't bother then, no worries.