HospitalRun / components

Reusable React components used by HospitalRun
https://components.hospitalrun.io
MIT License
124 stars 185 forks source link

Investigate `react/prop-types` eslint rule #499

Open matteovivona opened 4 years ago

matteovivona commented 4 years ago

Recently, a rule for react/prop-types was made a warning.

This issue is to investigate whether or not it is needed and to turn the rule off or to make it an error and fix the relevant code.

matteovivona commented 4 years ago

I added this annotation in the Modal.tsx

/* eslint react/prop-types: 0 */

@HospitalRun/core-contributor is that a rule we need? Otherwise, you can disable it globally with

  "rules": {
    "react/prop-types": 0
  }
jackcmeyer commented 4 years ago

For now, I have made this a warning.