HospitalRun / hospitalrun-frontend

Frontend for HospitalRun
https://staging.hospitalrun.io
MIT License
6.81k stars 2.18k forks source link

need forgot password link #6

Closed jglovier closed 4 years ago

jglovier commented 10 years ago

Right now if you forget your password, you are SOL. We should add a password recovery feature for users. Ideally, this would be part of the front end for users to trigger, but also something that admins could also trigger for users.

TODO

richchurcher commented 8 years ago

@tangollama I can take a look at this one.

tangollama commented 8 years ago

Awesome. Blossom. Please do. I'll take it off the help wanted list tomorrow.

Typed or dictated imperfectly on my iPhone (717.385.9970)

On Dec 5, 2015, at 6:45 PM, Rich Churcher notifications@github.com wrote:

@tangollama I can take a look at this one.

— Reply to this email directly or view it on GitHub.

tangollama commented 8 years ago

Removed Help Wanted as @richchurcher is looking into it.

jglovier commented 8 years ago

Bump. @richchurcher did you have a chance to look into this yet? Any update? When you get a PR open, feel free to cc me on it and I'll work with you on the styling.

tangollama commented 8 years ago

@richchurcher, I'm going to put this back in the Help Wanted pool for now. If you ping back, I'll mark as In Progress.

richchurcher commented 8 years ago

@tangollama I sincerely apologise for this lapse! I became crazy busy with work, and this fell off my radar entirely. I now no longer have the bandwidth to contribute as I had hoped, but best wishes for the project in the future!

dutad commented 8 years ago

I haven't even set up my dev environment for this project yet but I can look into this in the next few days. May take more than the allotted LOE because of being too busy...

tangollama commented 8 years ago

That's sounds great. If you want to tackle it, I'll be sure to flag it as in progress.

Typed or dictated imperfectly on my iPhone (717.385.9970)

On Apr 8, 2016, at 4:15 PM, Daniel Dut A. notifications@github.com wrote:

I haven't even set up my dev environment for this project yet but I can look into this in the next few days. May take more than the allotted LOE because of being too busy...

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

tangollama commented 8 years ago

@DanielDut how's this coming?

dutad commented 8 years ago

@tangollama, I have had difficulties running the project on my machine. I haven't started on it yet. I have a Windows-based PC and installing Cygwin was painfully unsuccessful. Trying it on a VM running Ubuntu is giving me build error on "Broccoli Plugin".

tangollama commented 8 years ago

@DanielDut any progress here? Should I move this back to Help Wanted?

dutad commented 8 years ago

@tangollama, I just got a new macbook air yesterday (just for this :) ) and setting up, let me get back to you in one week's time...

tangollama commented 8 years ago

@DanielDut, have you had a chance to work on this?

tangollama commented 8 years ago

@DanielDut any update here?

captain-enjoyable commented 8 years ago

@emurillo510 and I started on this task, and set up the necessary route. We weren't sure how to move forward without an api endpoint. image image

billybonks commented 8 years ago

@matteddy i think adding a forgot password route here would work https://github.com/HospitalRun/hospitalrun-server-routes/blob/master/routes/30-auth.js.

perhaps post '/auth/forgot' would be an appropriate route

@jkleinsc do you recommend a differen't route and a mailer ?

jkleinsc commented 8 years ago

@billybonks @matteddy yes I think putting it in the auth route makes sense and /auth/forgot works. As far as a mailer, maybe https://www.npmjs.com/package/nodemailer for flexibility but I am open to other suggestions.

EthanDavis commented 7 years ago

Is anyone still working on this if not I would be interesting in helping out.

broerse commented 7 years ago

@EthanDavis I am working on a serverless solution for this on our CouchDB projects. I also use nodemailer. See my first steps: https://github.com/martinic/openwhisk-mailer If I have all parts working it is perhaps interesting for reference.

jkleinsc commented 7 years ago

@EthanDavis it looks like effort on this has grown stale, so feel free to help out. This will require two pieces - the frontend as well as code added to https://github.com/HospitalRun/hospitalrun-server-routes/blob/master/routes/30-auth.js to handle the server side (eg email).

EthanDavis commented 7 years ago

@jkleinsc Okay thanks I will.

EthanDavis commented 7 years ago

@jkleinsc Should to forgot password link route to a new page or pull up a modal? This might take me more than a week. I'm not super familiar with Ember. Just want to make sure.

Thanks!

tangollama commented 7 years ago

@EthanDavis my apologies that I didn't reply sooner. Are you still interested in this issue? If not, I'll move it back to Help Wanted.

stukalin commented 6 years ago

@jglovier @tangollama @jkleinsc I started working on this issue. Which email transport should we use? I've had an old sendgrid acc, will use it so far for testing purposes. Does HR have some SMTP already or can we setup sendgrid or smt similar?

stukalin commented 6 years ago

Oh, wait, bullshit. There should be something more clever since we are not able to share a single api key among all our users... Some kind of SMTP transport configuration each user can configure on their own. Will think about that....

jkleinsc commented 6 years ago

@stukalin yeah, I would make it configurable.

jglovier commented 6 years ago

Is there a Node package for something like this? All we would really need to do is have the client ask the db for a reset pw link and send the user at that machine an email, right?

stukalin commented 6 years ago

@jglovier I double-checked and I think we still go with nodemailer and its default SMTP transport. Even if someone wants to use Send Grid or Mandrill or whatever, these services provide SMTP settings (at least these 2 do). So we should cover the majority of setups.

sarathsoma commented 5 years ago

@jglovier Is this still pending ? I can take this up

stukalin commented 5 years ago

it was pending, yes. I think I pushed my intermediate state into a branch with the corresponding name. Just look it up

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.