search

Hossein-s / skyroom-panel-assignment

0 stars 0 forks source link

Extra space #1

Open mkhahani opened 7 years ago

mkhahani commented 7 years ago

In some resolutions the space between icons is too much.

Furthermore I think we can have the two gadget boxes (i.e. not installed and outdated gadgets) in one row for wider screens like tablets.

control-panel

Hossein-s commented 7 years ago

Hi,

There was no other breakpoint in bootstrap grid system to fix this. I added on breakpoint to solve this problem and support that area.

Thanks for pointing this issue out.

Regards, Hossein Sadeghi

mkhahani commented 7 years ago

Yeah it works.

Regarding issue 1, why you not simply don't use float or table display for gadgets (icons)?

Hossein-s commented 7 years ago

If the container had fixed width, it would be the best approach. But since the container width is changing as the screen size changes, in cases that elements can't fit exact width of the container, it produces empty space at one side. By making the width of elements responsive, we distribute this empty space among all elements and it would be nicer. I think.

You can see below screenshot for more explanation. galaxy-s5-demo

Hossein-s commented 7 years ago

I have pushed a new branch to repository so you can see this in action.

mkhahani commented 7 years ago

You're right. Although the CSS3 Flex best fit for our need but lack of browsers support.