search

HosseinShabani / react-native-modern-datepicker

A customizable calendar, time & month picker for React Native (including Persian Jalaali calendar & locale)
MIT License
578 stars 164 forks source link

Calendar header and animation direction issue #24

Open peeyush-sahu opened 4 years ago

peeyush-sahu commented 4 years ago

https://github.com/HosseinShabani/react-native-modern-datepicker/issues/23#issuecomment-629250290

HosseinShabani commented 4 years ago

@peeyush-sahu let i check it now

peeyush-sahu commented 4 years ago

@peeyush-sahu let i check it now

Thanks for the prompt response.

HosseinShabani commented 4 years ago

@peeyush-sahu i reverse arrows direction , check it.

peeyush-sahu commented 4 years ago

@peeyush-sahu i reverse arrows direction , check it.

Arrow direction has changed. Thanks. Please change the sliding direction also as per LTR. For Example: If I am clicking right arrow than it the calendar should slide from right to left and when clicking left it should slide vice versa.

HosseinShabani commented 4 years ago

This direction is correct i think, moved from left to right when you tap right arrow.

Gustavo-Kuze commented 3 years ago

@HosseinShabani First of all, I'd like to thank you for this awesome component!

I agree with @peeyush-sahu. I think It should slide right to left when you click the right arrow, since you are going to next month. Right now It feels like you're going back when you click right.

kesha-antonov commented 2 years ago

@HosseinShabani First of all, I'd like to thank you for this awesome component!

I agree with @peeyush-sahu. I think It should slide right to left when you click the right arrow, since you are going to next month. Right now It feels like you're going back when you click right.

Agree with you guys. Please reverse animation directions @HosseinShabani ! 🙏

sate99 commented 2 years ago

@HosseinShabani I have fixed the above issue and raised the pr, please review and merge it.