Hosseinkakavand1376 / Computional-Intelligence

0 stars 0 forks source link

Peer Review Lab09 (called Lab3 in the repository) #5

Open marcocolangelo opened 9 months ago

marcocolangelo commented 9 months ago

Your code appears to be well-structured and organized, I have some comments and just some little tips for you:

1) I liked how you structured your code because building a GenomeOptimizer class makes your project more likely exportable for other future projects.

2) Be careful with your optimize_segment function, because you perform mutations until you reach a fitness of 1.0. This could potentially lead to infinite loops if a fitness of 1.0 is not achievable so It might be helpful to have an alternative stopping criterion, such as a maximum number of iterations. It's just a suggestion in case you want to adapt your code for future implementations.

3) Your plot_results function does a good job of visualizing the optimization results. It might be helpful to also include the fitness percentage in the displayed results in case of premature interruption as shown in the second comment above.

Overall, I liked it, working and easy to read