Hosung-Lee / log4jdbc

Automatically exported from code.google.com/p/log4jdbc
0 stars 0 forks source link

[PATCH] Bug on code that strips off the right JDBC URL #12

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The current code on SVN is buggy, as the prefix changed from jdbc:log to
jdbc:log4, but the calls to substring didn't. I'm submitting a quick and
dirty patch that simply replace the url.substring(9) calls to
url.substring(10), but ideally such logic should be refactored in a helper
method (which in turn calculates the size using a constant with the prefix).

Also, it might be necessary to update the project's documentation in order
to reflect the new prefix.

Original issue reported on code.google.com by felip...@gmail.com on 2 Sep 2009 at 10:03

Attachments:

GoogleCodeExporter commented 8 years ago
Why are you saying that this code is buggy?
The prefix has always been jdbc:log4 and the code is correct.

Original comment by arthur.b...@gmail.com on 1 Dec 2009 at 10:40

GoogleCodeExporter commented 8 years ago
Sorry, I filed this ticket almost 3 months ago, so I don't remember the 
details. I
believe the URL started with jdbc:log: before, at least I saw it in some docs;
regardless, the url.substring(9) doesn't not strip jdbc:log4: from the full 
URL, just
jdbc:log4, hence the bug (i.e., the new URL will start with :).

Anyways, maybe this is not an issue anymore, I am not using it to tell you for 
sure.

Original comment by felip...@gmail.com on 1 Dec 2009 at 11:01