Install - SQL Build version check has invalid references

HotcakesCommerce / hotcakes-commerce-cms

The content management engine that helps to run the CMS part of Hotcakes.

https://hotcakes.org

15 stars 9 forks source link

Install - SQL Build version check has invalid references #14

Closed AnonDevelopment closed 6 years ago

AnonDevelopment commented 7 years ago

Install has minimum requirement of SQL Server 2012. This would be build 11. References to builds are incorrect.

File Impacted: https://github.com/HotcakesCommerce/cms/blob/master/DNN%20Platform/Library/Services/Upgrade/Internals/InstallControllerImpl.cs

Reference: https://support.microsoft.com/en-ph/help/321185/how-to-determine-the-version,-edition-and-update-level-of-sql-server-a

WillStrohl commented 7 years ago

Nice catch! I've left a comment in your PR though. We need a change made before we can accept it.

WillStrohl commented 6 years ago

Thanks for your work on this. Unfortunately for you, we changed how we're distributing the Hotcakes Commerce CMS. It's now going to be purely a distribution model, so this issue and its related pull request are going to be closed. I'm sorry that we can't accept the pull request.