search

HotcakesCommerce / hotcakes-commerce-core

The core of the e-commerce part of the overall solution. This is an ecommerce shopping cart solution built on top of the DNN (DotNetNuke) CMS. Anyone can do commerce online now!
https://mmmcommerce.com
MIT License
68 stars 55 forks source link

Adding missing Xcillion Skin #344

Closed joshgk00 closed 2 years ago

joshgk00 commented 3 years ago

I was setting up a new dev environment for HCC and got my database setup according to the docs. When I went to run the development website I this DNN error

[D:2][T:9][ERROR] DotNetNuke.Services.Exceptions.Exceptions - DotNetNuke.Services.Exceptions.PageLoadException: Unhandled error loading page. ---> System.Web.HttpException: The file '/Portals/_default/Skins/Xcillion/Inner.ascx' does not exist.

Looks like the default Skin was missing from the repo.

This change will add the missing skin folder to the repo to resolve the above mentioned error when setting up a new dev environment

WillStrohl commented 3 years ago

This looks like you added and then deleted the PR changes. Was that intentional?

joshgk00 commented 3 years ago

This wasn't intentional. I can submit another PR for this change. Might be easier than trying to fix whatever I did on this PR

WillStrohl commented 3 years ago

Yes. Maybe that will be better. :) Thanks!

WillStrohl commented 2 years ago

Hmmm... It looks like this could be safely closed now. Am I seeing that correctly? 🤔

joshgk00 commented 2 years ago

You can close it out. I haven’t had a chance to resubmit the PR. When I get a chance I’ll check to see if it’s still an issue and make another PR.

From: Will Strohl @.> Sent: Tuesday, November 30, 2021 5:42 PM To: HotcakesCommerce/hotcakes-commerce-core @.> Cc: Josh Slaughter @.>; Author @.> Subject: Re: [HotcakesCommerce/hotcakes-commerce-core] Adding missing Xcillion Skin (#344)

Hmmm... It looks like this could be safely closed now. Am I seeing that correctly? 🤔

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/HotcakesCommerce/hotcakes-commerce-core/pull/344#issuecomment-983084875, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADIEQ2KDAN7UOJ7D7XSI7ETUOVHMDANCNFSM4XNJYRTQ.