search

HotcakesCommerce / hotcakes-commerce-core

The core of the e-commerce part of the overall solution. This is an ecommerce shopping cart solution built on top of the DNN (DotNetNuke) CMS. Anyone can do commerce online now!
https://mmmcommerce.com
MIT License
68 stars 55 forks source link

Fix Installer generated by HCC (BUG) #413

Closed ArielBlanco1990 closed 1 year ago

ArielBlanco1990 commented 1 year ago

Removed unnecessary assembly reference within the manifest.

Fixed #412

WillStrohl commented 1 year ago

FYI - This isn't the correct fix for this issue. If the DLL is missing, the fix isn't to remove the code that expects it to be there. The code should be updated to be sure to move the DLL. This is most likely a bug in the build process, not the DNN manifest.

The way this PR is done, the DLL still won't be copied, but DNN won't complain about it, because there isn't a reference to it.

ArielBlanco1990 commented 1 year ago

I was reviewing the previous Releases of Hotcakes and there was a library with the name Hotcakes.Shipping.Ups.Keys

03 02 03_Librarys

this was removed in the last release

03 06 00_Libraries

but they forgot to remove the reference inside the manifest, so when we try to install the extension we get this error.

03 06 00_Manifest_Lost_DLL

As shown it seems that this library was removed in some update

It may have happened here: Replace Ups registration with login #398

https://github.com/HotcakesCommerce/hotcakes-commerce-core/pull/398/commits/43a6c6f138b5646eb64562db36969fb1cb06580d

WillStrohl commented 1 year ago

Ah! Thank you for pointing that out. I (obviously) completely missed that. 😎

ArielBlanco1990 commented 1 year ago

The Update Method FindManyWithCache commit was an error, so it was reverted. As the PullRequest Fix Installer generated by HCC (BUG) #413 was approved but was not merged, the new change was added within the same branch. I reverted the change and created a new branch with the new changes.