search

HotcakesCommerce / hotcakes-commerce-core

The core of the e-commerce part of the overall solution. This is an ecommerce shopping cart solution built on top of the DNN (DotNetNuke) CMS. Anyone can do commerce online now!
https://mmmcommerce.com
MIT License
69 stars 55 forks source link

Hcc Update Entity Framework #432

Closed ArielBlanco1990 closed 1 year ago

ArielBlanco1990 commented 1 year ago

Description of PR...

The PR aims to migrate the version of the HCC EntityFramework from the current version 6.1.1 to version 6.4.4.

EF 6.4.0

The EF 6.4.0 runtime was released to NuGet in December 2019. The primary goal of EF 6.4 is to polish the features and scenarios that was delivered in EF 6.3. See list of important fixes on GitHub.

https://github.com/dotnet/ef6/milestone/14?closed=1

Changes made

Close #430

ArielBlanco1990 commented 1 year ago

I'll go through all the comments and see if there's anything I can remove and get everything working correctly. I understand the comments you have made. I will check one by one.

ArielBlanco1990 commented 1 year ago

Please, do not approve this PR until I tell you it is ready for review. I have had some problems. After the new commits I have noticed something that should not happen.

WillStrohl commented 1 year ago

Please, do not approve this PR until I tell you it is ready for review. I have had some problems. After the new commits I have noticed something that should not happen.

@ArielBlanco1990 I'm reviewing this PR now, per your internal note about completing the updates. :)

ArielBlanco1990 commented 1 year ago

Hi @WillStrohl : Yes after carrying out all the tests on my part it is ready to merge.