Hotrian / OpenVRDesktopDisplayPortal

Put your favorite Desktop Window directly into any OpenVR game!
Other
445 stars 97 forks source link

Automatically select the 'other' controller when loading a profile when the selected controller is absent #44

Closed Hotrian closed 7 years ago

Hotrian commented 7 years ago

I think this is still a thing and don't want to forget to fix it. When you load a controller profile and the selected controller isn't available, I believe the Overlay defaults to Screen. Instead, when the Left Controller is selected and only the Right Controller is found, it should select the Right Controller, and vice versa.

I don't think I ever patched this, and it is useful for people who only use one controller or the other for whatever reason.

If the other controller is turned on, maybe it should automatically switch back to the other controller (which would have been the one it would have attached to in the first place)? At this point though I think there's a decent chance the controllers would have been misidentified, since SteamVR only assigns roles when both controllers are connected and tracking, and if no roles are found OVRDDP assigns them automatically (hence the Swap Controllers button, for when OVRDDP has assigned them incorrectly to the way you are using them, where as SteamVR will automatically reassign roles if you put them down for a few minutes and pick them back up. I could set OVRDDP to automatically update the roles when SteamVR reassigns them, but I think I like it better as Manual for now)

Hotrian commented 7 years ago

Pretty sure this is fixed already but I need to do some thorough testing before closing. Currently it does not automatically switch back to the saved controller but it's as easy as pressing the Swap Controllers button, since this just swaps which controller OVRDDP has identified as which and nothing else.