Dcevm11 jdk 11.0.7 - Githubissues

HotswapProjects / openjdk-jdk11u-dcevm

Dcevm11 sources, binaries are available at https://travis-ci.org/TravaOpenJDK/trava-jdk-11-dcevm

GNU General Public License v2.0

30 stars 10 forks source link

Dcevm11 jdk 11.0.7 #7

Closed ruediste closed 4 years ago

ruediste commented 4 years ago

I tried to update DCEVM to jdk 11.0.7+10, which is the current ubuntu openjdk version. Noted during merge:

there was a merge conflict in make/common/MakeBase.gmk. Just took the upstream version, build worked. (commit e95ddaebdfd137848d4999e8d0031cb3575fdc8d)
vm_operations.hpp was renamed to vmOperations.hpp (in b13adb93dc10b421012e524434e81aa4abfb602b). Updated Apply basic dcevm11 patch

skybber commented 4 years ago

Hi, I've created a new branch for it dcevm11-jdk-11.0.7 and do some housekeeping in the dcevm today, it should include your patches. It looks, we have been worked on it simultaneously :) I've reorganized, merged some commits in dcevm patch to be more transparent.

ruediste commented 4 years ago

Cool, I'll close the pull request. Just had a look at the diff. I observed the following:

it seems you based the branch on tag jdk-11.0.7+10 and not jdk-11.0.7+10_adopt. Before the _adopt tags were used. Any reason?
jvmtiEnhancedRedefineClasses.hpp: #include "runtime/vmOperations.hpp" not needed anymore? Nice cleanup.

skybber commented 4 years ago

Hi, thanks for review! Correct branch should be jdk-11.0.7_adopt, its my mistake. I'll create a new branch for it (.._adopt). #include "runtime/vmOperations.hpp" is not necessary.