Include a summary of major changes in bullet points:
Fix selenium style changes
Fix xpath
Fix page loading issue
Additional dependencies introduced (if any)
List all new dependencies needed and justify why. While adding dependencies that bring
significantly useful functionality is perfectly fine, adding ones that
add trivial functionality, e.g., to use one single easily implementable
function, is frowned upon. Provide a justification why that dependency is needed.
Especially frowned upon are circular dependencies, e.g., depending on derivative
modules of pymatgen such as custodian or Fireworks.
TODO (if any)
If this is a work-in-progress, write something about what else needs
to be done
Feature 1 supports A, but not B.
Checklist
Work-in-progress pull requests are encouraged. Please put [WIP]
in the pull request title.
Before a pull request can be merged, the following items must be checked:
[x] Code is in the standard Python style. The easiest way to handle this
is to run the following in the correct sequence on your local machine. Start with running
black on your new code. This will automatically reformat
your code to PEP8 conventions and removes most issues. Then run
pycodestyle, followed by
flake8.
Summary
Include a summary of major changes in bullet points:
Additional dependencies introduced (if any)
TODO (if any)
If this is a work-in-progress, write something about what else needs to be done
Checklist
Work-in-progress pull requests are encouraged. Please put [WIP] in the pull request title.
Before a pull request can be merged, the following items must be checked: