Open jonuhal opened 10 years ago
Thanks for your response. I recommend you not upgrade right now, just use previous version, it's absolutely ok.
As for new version, please check this example: https://github.com/Houdini/TwoFactorAuthenticationExample
About migration and undefined method `scan' for nil:NilClass, please give me a week, I'll prepare how to migrate section in documentation.
Is there a quick fix avail for the issue with scan?
As I understand, the problem with scan is that otp_secret_key is nil and it shouldn't. Why it's nil?
Probably you use previous version, when we didn't generate otp_secret_key in before_save action yet. If this is the case, you should update gem and manually create otp_secret_key (and of course share it with your users)
May be better solution is to ignore two_factor_authentication if otp_secret_key is nil in need_two_factor_authentication? method
Ok. It wasn't clear in the docs. that we needed to gen. I'll have another go.
@simonmorley Would be great if you add FAQ to main README.md in good english about that.
I can probably do this :) Also worth mentioning in the upgrade path that the deps have been updated significantly too.
After updating the gem I know have Rails 4.1 and the misery that accompanies it. This isn't really a problem with your stuff, more of a general notice.
On another note, we were in the process of redoing version 2 to support custom word lists - we discovered the English dictionary has a number of pretty offensive words in it!
Not sure where that now fits though and I prefer your new and more secure functionality.
How would you feel about including the word list stuff as an addon?
Not sure about word list addon. Solution with rotp is better and more scalable.
In my view missing feature right now is backup codes.
Using the new remember_otp_session configuration. Had to manually go into the gem's directory to update. Works locally but trying to build to production (jenkins), and new configurations aren't there. Have you worked out how to migrate the changes?