Change update_attributes to update_columns

Houdini / two_factor_authentication

Two factor authentication extension for Devise

MIT License

400 stars 267 forks source link

Closed r6e closed 2 years ago

r6e commented 2 years ago

There are two problems using update_attributes:

It is deprecated and was removed in Rails 6.1
It validates the record. If a user updates their OTP code on their device, but the record fails to save, the two will be out of sync. Other devise extensions skip validations for this reason, so we should too.

This change is a simple replacement of update_attributes with update_columns.

r6e commented 2 years ago

Wrong repo :/