HoudiniGraphql / houdini

The disappearing GraphQL framework
http://www.houdinigraphql.com
MIT License
913 stars 98 forks source link

Strip unused variables on their way out #1330

Closed AlecAivazis closed 3 months ago

AlecAivazis commented 3 months ago

Fixes https://discord.com/channels/1024421016405016718/1268152875914104853

This PR fixes an issue when using the @parentID directive powered by a query variable. Before the variable would be sent along with the query (even tho it wasn't actually used). In some server runtimes, this causes an error.

To help everyone out, please make sure your PR does the following:

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 34f24a5896761d0dc1ce29fd837f7db41c94e1f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages | Name | Type | | ----------------------------------- | ----- | | houdini | Patch | | houdini-adapter-auto | Patch | | houdini-adapter-cloudflare | Patch | | houdini-adapter-node | Patch | | houdini-adapter-static | Patch | | houdini-react | Patch | | houdini-svelte | Patch | | houdini-plugin-svelte-global-stores | Patch | | create-houdini | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for houdinigraphql canceled.

Name Link
Latest commit 34f24a5896761d0dc1ce29fd837f7db41c94e1f1
Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/66abc023d1fddb00087ebbd9
netlify[bot] commented 3 months ago

Deploy Preview for houdini-docs-next canceled.

Name Link
Latest commit 34f24a5896761d0dc1ce29fd837f7db41c94e1f1
Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/66abc02387a7fa0008aedbdb