HoudiniGraphql / houdini

The disappearing GraphQL framework
http://www.houdinigraphql.com
MIT License
913 stars 98 forks source link

Fix return types for pagination handlers #1362

Closed SeppahBaws closed 1 month ago

SeppahBaws commented 1 month ago

This fixes a subtle bug that crept in with #1352, where the return types for loadNextPage and loadPreviousPage became Promise<QueryResult<_Data, _Input> | undefined> instead of the Promise<QueryResult<_Data, _Input>> as defined by the CursorHandlers type.

To help everyone out, please make sure your PR does the following:

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 08cdc95aaa8ddc8555024ae33bc34b8924c225c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages | Name | Type | | ----------------------------------- | ----- | | houdini-svelte | Patch | | houdini-plugin-svelte-global-stores | Patch | | houdini-adapter-auto | Patch | | houdini-adapter-cloudflare | Patch | | houdini-adapter-node | Patch | | houdini-adapter-static | Patch | | houdini-react | Patch | | houdini | Patch | | create-houdini | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for houdini-docs-next canceled.

Name Link
Latest commit 08cdc95aaa8ddc8555024ae33bc34b8924c225c6
Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/66fc4729aec2e200084cf587
netlify[bot] commented 1 month ago

Deploy Preview for houdinigraphql canceled.

Name Link
Latest commit 08cdc95aaa8ddc8555024ae33bc34b8924c225c6
Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/66fc47295994f80008d24f65