SyncInputs should have a more C#-friendly interface

HouraiTeahouse / Backroll

Unity C# Port of GGPO built atop Hourai Networking

MIT License

131 stars 10 forks source link

SyncInputs should have a more C#-friendly interface #10

Closed james7132 closed 1 year ago

james7132 commented 3 years ago

Currently BackrollSession.SyncInputs uses a C-like interface of a mutable void* and a buffer length. This presents several issues:

It requires an unsafe interface.
It's not type safe.
Inexperienced programmers may easily lead to buffer overflow if mishandled.
It's unusual for a good number of C# developers.

Instead of using a buffer + length, we could use a type safe generic function instead that returns a ReadOnlySpan of the inputs, which would resolve all of the above issues.

james7132 commented 1 year ago

At this rate, please use UnityGGPO, I'm more focused on maintaining the Rust version of this library than the Unity C# one.