StartSession fails if an array of spectators is not provided, even if there are none.

HouraiTeahouse / Backroll

Unity C# Port of GGPO built atop Hourai Networking

MIT License

131 stars 10 forks source link

StartSession fails if an array of spectators is not provided, even if there are none. #8

Closed goodiesohhi closed 1 year ago

goodiesohhi commented 3 years ago

In the P2PBackrollSession(BackrollSessionConfig config) constructor, it does. _players = InitializeConnections(config.Players); _spectators = InitializeConnections(config.Spectators); even if there are no spectators.

Which is a problem because it then tries to initialize connections to all spectators which there are none of, this fails the Assert.IsNotNull(members); assert and throws error.

james7132 commented 1 year ago

At this rate, please use UnityGGPO, I'm more focused on maintaining the Rust version of this library than the Unity C# one.