Closed seanchen1991 closed 3 years ago
Main question is if we should rename BackrollError or BackrollResult, everything else looks 👌.
I don’t generally see crates name their internally-defined Error
and Result
types as such, as it could clash with the built-in Error
and Result
types, which is why I didn’t rename them.
Alright sounds good to me.
This PR renames the following:
BackrollConfig
toConfig
BackrollPlayer
toPlayer
BackrollPlayerHandle
toPlayerHandle
BackrollEvent
toEvent
BackrollPeer
toPeer
BackrollPeerConfig
toPeerConfig
BackrollSync
toSync
backroll::sync::Config
toPlayerConfig
bevy_backroll::BackrollStageCallbacks
toStageCallbacks
To avoid naming conflicts in
protocol/mod.rs
,transport::Peer
is namespaced asTransportPeer
andprotocol::Event
is namespaced toProtocolEvent
.I also took the liberty of addressing default clippy warnings.
Let me know if any of these changes aren't acceptable 🙂