HouraiTeahouse / backroll-rs

A (almost) 100% pure safe Rust implementation of GGPO-style rollback netcode.
ISC License
351 stars 20 forks source link

Remove Backroll prefixes #10

Closed seanchen1991 closed 3 years ago

seanchen1991 commented 3 years ago

This PR renames the following:

To avoid naming conflicts in protocol/mod.rs, transport::Peer is namespaced as TransportPeer and protocol::Event is namespaced to ProtocolEvent.

I also took the liberty of addressing default clippy warnings.

Let me know if any of these changes aren't acceptable 🙂

james7132 commented 3 years ago

Main question is if we should rename BackrollError or BackrollResult, everything else looks 👌.

seanchen1991 commented 3 years ago

I don’t generally see crates name their internally-defined Error and Result types as such, as it could clash with the built-in Error and Result types, which is why I didn’t rename them.

james7132 commented 3 years ago

Alright sounds good to me.