House-of-M / contributors-wall

All contributors level are welcome to check-in and tag their name on the wall! Beginner friendly, no code knowledge required to contribute.

https://house-of-m.github.io/contributors-wall/

7 stars 18 forks source link

Dark mode theme #4

Closed IndigoWizard closed 2 years ago

IndigoWizard commented 2 years ago

Info

So far the live website of the repo has only one light theme. It would be great to have a dark theme switch as well.

How

Feel free to to use either CSS or JavaScript (vanilla preferably) to build a theme switch.
In the CSS :root element you'll find an already setup color palette, use them to build the color palette for dark theme mode (feel free to add some colors if needed).
The main logo SVGs are available in two colors; white & red. use what suits the theme for better visibility.

PR

Please explain what method you used and how you built the feature (briefly).
Make sure to include some screenshots for the results in your Pull Request submission (you can put them in a markdown table if you're doing a comparison if you wish).

Notes:

Keep css variable naming convention as setup in the style sheet.
If you are opting for JS, please mind to create a folder dedicated for scripts inside src folder as ./src/scripts.

Pavan-Nambi commented 2 years ago

can you assign me for this?

IndigoWizard commented 2 years ago

@pavan-nambi yup, you're up!

Pavan-Nambi commented 2 years ago

so basically you want user to click on a button or just by default through his system preferences??

Pavan-Nambi commented 2 years ago

i did as per users system mode lmk if its not the case

IndigoWizard commented 2 years ago

@pavan-nambi It's preferable to have a switch button. Intending on requesting more issues on custom themes in the future for other beginner contributors.

Pavan-Nambi commented 2 years ago

can you check i guess its finished

Pavan-Nambi commented 2 years ago

@IndigoWizard

Pavan-Nambi commented 2 years ago

ignore first commit as it was based on system os mode in second commit its changing imo idk why you added main tag

IndigoWizard commented 2 years ago

@pavan-nambi alright i'll give it a quick check

Pavan-Nambi commented 2 years ago

i'll be heading off to sleep , sorry if i commented many times lol this is my first pr so i am a bit anxious and nervous if anything has to be changed i will try tomorrow

IndigoWizard commented 2 years ago

@pavan-nambi It's alright, you're doing fine. This is part of the usual pipeline when it comes to contributing ton an open source project. Us maintainers can be meticulous about things sometimes x) but sure, you can finish the final edits tomorrow according to the latest recommendation in the PR #6 and you should be good to go.

Akanksha2403 commented 2 years ago

hello sir, could you please assign me this project

IndigoWizard commented 2 years ago

Hey @Akanksha2403 ! Glad to have enthusiast contributors. Unfortunately for the moment, this issue is already assigned to someone else, it's up to @pavan-nambi and his already submitted PR is ongoing with minor change requests. Once the PR is fully setup and inspected, we may move to update the issue with new tasks you can contribute to.

Mihir008 commented 2 years ago

Hello sir, could you please assign me this???

IndigoWizard commented 2 years ago

@Mihir008 hey! Please refer to my previous comment on the thread above your comment for current state of the issue.

Mihir008 commented 2 years ago

@IndigoWizard so sorry i didnt see that! waiting for your further tasks

Pavan-Nambi commented 2 years ago

alright

IndigoWizard commented 2 years ago

This issue has been resolved with the merging of the Pull Request #6 and closes it.