search

HousewareHQ / backend-engineering-octernship

24 stars 13 forks source link

Submitting Changes #6

Open Adedunmol opened 1 year ago

Adedunmol commented 1 year ago

Am I supposed to fork the project and work on the main branch of the fork and push the changes to the main branch and wait for it to be reviewed?

I'm a little bit confused.

thepranays commented 1 year ago

what i have understood from the instructions that we have to make changes on feedback and then make PR from it to main branch

Adedunmol commented 1 year ago

I tried submitting a change on feedback and that closed the feedback PR for me, which is not meant to be closed unless instructed to.

thepranays commented 1 year ago

@Adedunmol I have done the same , I hope someone from houseware replies,Till then i guess at the end we can open new PR from feedback to main to merge hope that will work

Adedunmol commented 1 year ago

All right. Thank you. I don’t know if what I’m doing is right but I’m trying to make all the changes on the main branch of my fork and then push everything to feedback branch.