search

HousewareHQ / frontend-engineering-octernship

45 stars 55 forks source link

Pull Request #16

Closed ARYA-RAY closed 1 year ago

ARYA-RAY commented 1 year ago

I have pushed my changes to the main branch, do I have to make a PR now? or will it be automatically checked?

YessBlack commented 1 year ago

I also have the same doubt

narayan954 commented 1 year ago

I have pushed my changes to the main branch, do I have to make a PR now? or will it be automatically checked?

if you made the commits to the main branch, that's fine according to the updated readme instructions. You should be able to see the committed changes in the auto generated pull request which will be the one to be graded actually.

ARYA-RAY commented 1 year ago

@narayan954 actually i did the entire work in the feedback branch as it was mentioned before , then i merged the changes to the main branch, so the only commit shown in the auto generated pr is the 'merge feedback to main' all the other commits are in the feedback branch, will this be a problem?