search

HousewareHQ / frontend-engineering-octernship

45 stars 54 forks source link

merge to main after pushing to feedback? #20

Closed sohamdata closed 1 year ago

sohamdata commented 1 year ago

I've made two commits and pushed to the feedback branch and made a PR. Should I merge with the main branch? The task description: Making changes on the auto generated feedback branch to complete the task pr: https://github.com/HousewareHQ/houseware---frontend-engineering-octernship-sohamdata/pull/2

babboe1 commented 1 year ago

I think the instructions have been updated, we are asked to add our final changes to the main branch of our private repo, what I think is that after pushing to the feedback branch a PR should be made to the main branch, since we were asked to add it to the main branch then i guess it ough't to be merged