search

HousewareHQ / frontend-engineering-octernship

45 stars 54 forks source link

octernship details #4

Closed debanjo31 closed 1 year ago

debanjo31 commented 1 year ago

do I install a new react app to work on this project? how do I submit it after working on this project?

Thanks

samuel-ma commented 1 year ago

@debanjo31 Just create a fork and load it on your local device Run it on your code editor as usual and work on the task Once your done, just return to this repo and create a pull request and wait for a review The readme is pretty detailed, walks you thru everything

Let me know what your stuck on exactly

manaver commented 1 year ago

@samuel-ma i completed my project and pushed it in feedback branch and it automatically merged. Now do i need to wait for feedback? Also there is no discussion tab for doubts? And one more question do i need to write about project or only installation procedure in readme? Thanks!

samuel-ma commented 1 year ago

@manaver, wait for a review of your project You'll receive an email once it's been reviewed so check your emails.

manaver commented 1 year ago

Thanks @samuel-ma

rahulaarora commented 1 year ago

Hi @samuel-ma, I have completed the assignment and committed to the Main branch, do I have to merge it with the feedback branch? Thanks!

SamChus commented 1 year ago

@manaver, that means we are to pitch our code to the feedback branch?

manaver commented 1 year ago

@SamChus i am not really sure is this correct. I follow readme file and push my changes to feedback branch.

CyberGA commented 1 year ago

@SamChus i am not really sure is this correct. I follow readme file and push my changes to feedback branch.

This is right

shubh24 commented 1 year ago

Please refer to #6 for details regarding submissions