Houston4444 / RaySession

Session manager for linux musical programs
GNU General Public License v2.0
168 stars 20 forks source link

Client templates for "Calf JACK Host" and "JACK Mixer" cannot be packaged as-is due to spaces in directory names #209

Closed eeickmeyer closed 11 months ago

eeickmeyer commented 11 months ago

Due to Debian policy and inability to put conffiles with spaces in /etc, the client templates for "Calf JACK Host" and "JACK Mixer" cannot be packaged for Debian and Ubuntu as-is as it breaks policy and causes packaging errors. Additionally, the spaces in the filename get misinterpreted causing further errors:

E: raysession: file-in-etc-not-marked-as-conffile [etc/xdg/raysession/client_templates/60_ray_lash/Calf JACK Host/XXX_SESSION_NAME_XXX.XXX_CLIENT_ID_XXX/XXX_SESSION_NAME_XXX.calf]
E: raysession: file-in-etc-not-marked-as-conffile [etc/xdg/raysession/client_templates/60_ray_lash/Jack Mixer/XXX_SESSION_NAME_XXX.XXX_CLIENT_ID_XXX/XXX_SESSION_NAME_XXX.xml]
E: raysession: missing-conffile Host/XXX_SESSION_NAME_XXX.XXX_CLIENT_ID_XXX/XXX_SESSION_NAME_XXX.calf [conffiles:2]
E: raysession: missing-conffile Mixer/XXX_SESSION_NAME_XXX.XXX_CLIENT_ID_XXX/XXX_SESSION_NAME_XXX.xml [conffiles:3]
E: raysession: non-etc-file-marked-as-conffile Host/XXX_SESSION_NAME_XXX.XXX_CLIENT_ID_XXX/XXX_SESSION_NAME_XXX.calf [conffiles:2]
E: raysession: non-etc-file-marked-as-conffile Mixer/XXX_SESSION_NAME_XXX.XXX_CLIENT_ID_XXX/XXX_SESSION_NAME_XXX.xml [conffiles:3]
E: raysession: relative-conffile Host/XXX_SESSION_NAME_XXX.XXX_CLIENT_ID_XXX/XXX_SESSION_NAME_XXX.calf [conffiles:2]
E: raysession: relative-conffile Mixer/XXX_SESSION_NAME_XXX.XXX_CLIENT_ID_XXX/XXX_SESSION_NAME_XXX.xml [conffiles:3]
E: raysession: unknown-conffile-instruction /etc/xdg/raysession/client_templates/60_ray_lash/Calf [conffiles:2]
E: raysession: unknown-conffile-instruction /etc/xdg/raysession/client_templates/60_ray_lash/Jack [conffiles:3]
N:
E: raysession: unknown-conffile-instruction JACK [conffiles:2]

These errors cannot be overridden.

I propose a simple change to the directory name and client-templates.xml if possible.

Houston4444 commented 11 months ago

Ok, last commit fixes this: https://github.com/Houston4444/RaySession/commit/f24fa31ca6175392c2cc9f3891b6b0918243f462.

I removed the Jack Mixer template, because Jack Mixer has NSM support for a long time now, and it was impossible to prevent to list this ray-hack (LASH) template when jack_mixer is installed.