Fix executable bits and add Mixbus 9 and Mixbus32c 8 and 9 templates

Houston4444 / RaySession

Session manager for linux musical programs

GNU General Public License v2.0

150 stars 18 forks source link

Fix executable bits and add Mixbus 9 and Mixbus32c 8 and 9 templates #210

Closed eeickmeyer closed 8 months ago

eeickmeyer commented 8 months ago

The commit name is a bit wrong, should be "add mixbus 9 and mixbus32c 8 and 9," but it was late and I was tired apparenty. Since Mixbus32c is also a derivative of Ardour, it makes sense to include the two most recent versions of that as well. Also, the most recent version of Mixbus (non-32c) is 9, so this adds that as well.

Additionally, many components that should be executable are not, so this fixes that.

Houston4444 commented 8 months ago

Thanks for this.

In client_templates.xml, a quote is missing line 21 after "executable=".

About executables, it should be another PR, because it is not linked at all with the Mixbus templates. I answer quickly anyway:

files in data/ have not to be executable, they are templates, if you read there contents you will see they can not work.
files in session_scripts should be executable indeed
it seems that src/bin/utility_script_start.sh is not used at all, it could be removed
files in src/jack_config_script have not to be executable, they are loaded by those that are.

Houston4444 commented 8 months ago

Could you restart a PR only with Mixbus templates ?

eeickmeyer commented 8 months ago

I can restart with only the Mixbus templates but...

files in src/jack_config_script have not to be executable, they are loaded by those that are.

Unfortunately, I'll still have to downstream patch that as any script with a shebang (#!/bin/sh or #!/bin/bash) still must be marked as executable per Debian packaging policy.